RFR: 8339289: Enhance Attach API to support arbitrary length arguments - Windows [v4]

[Alex Menkov]

On Thu, 24 Oct 2024 12:37:24 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - updated comment
>>  - feedback
>
> src/hotspot/share/services/attachListener.cpp line 406:
> 
>> 404:   { "printflag",        print_flag },
>> 405:   { "jcmd",             jcmd },
>> 406:   { "getVersion",       get_version },
> 
> It's a bit of a nit, but "dumpheap" and other existing commands never use caps but the new "getVersion" does?

We have "agentProperties" command, but this is the only exception.
Renamed to "getversion".

> src/hotspot/share/services/attachListener.hpp line 65:
> 
>> 63: /*
>> 64: Version 1 (since jdk6): attach operations always have 3 (AttachOparation::arg_count_max)
>> 65:   arguments, each up to 1024 (AttachOparation::arg_length_max) symbols.
> 
> "AttachOparation" typo and also "symbols" is clarified to mean characters in a review comment, so should probably change that here and also in attachListener.cpp 626, 627.
> CompatTest.java says "1024 symbols"

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20782#discussion_r1815562279
PR Review Comment: https://git.openjdk.org/jdk/pull/20782#discussion_r1815560165