RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]

Weijun Wang weijun at openjdk.org
Fri Oct 25 23:47:43 UTC 2024


On Fri, 25 Oct 2024 20:53:23 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> src/java.base/share/classes/java/security/AccessControlContext.java line 141:
>> 
>>> 139:         throws AccessControlException
>>> 140:     {
>>> 141:         throw new AccessControlException("");
>> 
>> No message for this exception?
>
> I'm not sure what would be a useful message. All the `SecurityManager` check methods throw a `SecurityException` with no message. We had to specify something here because `AccessControlException` doesn't have a no-args ctor.

I see. Maybe this is enough.

>> src/java.base/share/classes/java/security/AccessControlException.java line 29:
>> 
>>> 27: 
>>> 28: /**
>>> 29:  *
>> 
>> Add a sentence like "This was..."?
>
> You mean move the first sentence of the deprecated text to here?

Oh, I just meant the class spec should have a body text. This is similar to my previous comment on the `Policy` class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1817452801
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1817452658


More information about the serviceability-dev mailing list