RFR: 8304824: NMT should not use ThreadCritical [v8]

Robert Toyonaga duke at openjdk.org
Mon Oct 28 16:12:39 UTC 2024


On Mon, 28 Oct 2024 16:03:32 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Otherwise `make test TEST=hotspot_nmt` throws a lock rank error when running the test  `location_printing_mmap_1`. That test uses `MemTracker::print_containing_region`.
>
> Thanks. But eew. Okay, ugly but not easy to fix.
> Can you please add a trailing comment behind SharedDecoder lock that it needs to be lower than the NMT lock?

yes ok, I can add an explanatory comment there

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20852#discussion_r1819342359


More information about the serviceability-dev mailing list