RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v11]
Alan Bateman
alanb at openjdk.org
Tue Oct 29 16:16:14 UTC 2024
On Tue, 29 Oct 2024 16:01:49 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port. This port was [deprecated for removal in JDK 21](https://openjdk.org/jeps/449) with the express intent to remove it in a future release.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>
> IS_WIN64 is never used and can be completely removed
src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c line 236:
> 234: * On Windows we need to handle 32-bit tools trying to attach to 64-bit
> 235: * processes, which is currently not supported by this implementation.
> 236: */
The tool side uses the attach API so the potential scenario is a tool on 64-bit attempting to attach to a target VM that is 32-bit. So the comment needs to re-phased to the reverse of what it says now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1821145158
More information about the serviceability-dev
mailing list