RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]

Harshitha Onkar honkar at openjdk.org
Tue Oct 29 17:10:54 UTC 2024


On Thu, 24 Oct 2024 15:03:23 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Sean Mullan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 150 commits:
>> 
>>  - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>>  - Merge
>>  - Update @summary to replace "if the right permission is granted" can be replaced with "package java.lang is open to unnamed module".
>>  - Remove println about Security Manager.
>>  - Remove unused static variable NEW_PROXY_IN_PKG.
>>  - Remove static variable `DEFAULT_POLICY` and unused imports.
>>  - Remove hasSM() method and code that calls it, and remove comment about
>>    running test manually with SM.
>>  - clientlibs: import order
>>  - warning-string
>>  - java/net/httpclient/websocket/security/WSURLPermissionTest.java: integrated review feedback in renamed WSSanityTest.java
>>  - ... and 140 more: https://git.openjdk.org/jdk/compare/f7a61fce...cb50dfde
>
> src/java.desktop/share/classes/java/awt/Font.java line 1613:
> 
>> 1611:      * interpreted as a {@code Font} object according to the
>> 1612:      * specification of {@code Font.decode(String)}
>> 1613:      * If the specified property is not found then null is returned instead.
> 
> Suggestion:
> 
>      * If the specified property is not found, null is returned instead.
> 
> The old description didn't have ‘then’, it can be dropped. A comma to separate the conditional clause from the main one makes the sentence easier to read.

Updated on jep486 branch

> src/java.desktop/share/classes/java/awt/Font.java line 1781:
> 
>> 1779:      * The property value should be one of the forms accepted by
>> 1780:      * {@code Font.decode(String)}
>> 1781:      * If the specified property is not found then the {@code font}
> 
> Suggestion:
> 
>      * If the specified property is not found, the {@code font}

Updated on jep486 branch

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1821237100
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1821236441


More information about the serviceability-dev mailing list