RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v16]

Dean Long dlong at openjdk.org
Tue Oct 29 21:00:30 UTC 2024


On Tue, 29 Oct 2024 19:04:57 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/frame_aarch64.hpp line 77:
>> 
>>> 75:     // Interpreter frames
>>> 76:     interpreter_frame_result_handler_offset          =  3, // for native calls only
>>> 77:     interpreter_frame_oop_temp_offset                =  2, // for native calls only
>> 
>> This conflicts with sender_sp_offset.  Doesn't that cause a problem?
>
> No, it just happens to be stored at the sender_sp marker. We were already making room for two words but only using one.

`sender_sp_offset` is listed under "All frames", but I guess that's wrong and should be changed.  Can we fix the comments to match x86, which lists this offset under "non-interpreter frames"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1821524020


More information about the serviceability-dev mailing list