RFR: 8304824: NMT should not use ThreadCritical [v3]

[Johan Sjölen]

On Wed, 30 Oct 2024 13:39:00 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

>I'm not certain, but looking at it again, it seems that the ThreadCritical uses in ChunkPool::deallocate_chunk and ChunkPool::prune() are only needed for NMT and are independent of the other ThreadCritical uses in that code.

At least for prune, that's needed for the chunk pool itself as it would otherwise be accessed concurrently.

>Also, those uses of ThreadCritical are not protecting NMT's model of virtual memory. They are only protecting the reporting of malloc info specifically. Although, it may still make sense to replace those instances with NmtVirtualMemory_lock since it's is still related to NMT.

OK, I understand. That seems reasonable.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20852#issuecomment-2447477881