RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v3]

[Julian Waters]

On Wed, 30 Oct 2024 06:27:22 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into unused
>>  - 8342682
>
> src/jdk.jdi/windows/native/libdt_shmem/shmem_md.c line 40:
> 
>> 38:  */
>> 39: 
>> 40: // static HANDLE memHandle = NULL;
> 
> I still think this should be removed instead of commented out.

I was more fond of keeping it as a comment, but oh well. Give me a moment...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21616#discussion_r1823903506