RFR: 8304824: NMT should not use ThreadCritical [v9]
Thomas Stuefe
stuefe at openjdk.org
Thu Oct 31 09:05:36 UTC 2024
On Wed, 30 Oct 2024 15:57:57 GMT, Robert Toyonaga <duke at openjdk.org> wrote:
> So that means we'd need to have both ThreadCritical and NmtVirtualMemory_lock in that method (if we were to do the other replacements). One to protect the chunks and one to protect the malloc accounting. It might also be good to rename NmtVirtualMemory_lock then too.
Please split this code in two parts. First part removes retired chunks from the arena chunk list and adds them to a new temporary list. Second part goes through the temp list and deletes the chunks. First part under ThreadCritical, second part under `NmtVirtualMemory_lock`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20852#issuecomment-2449366080
More information about the serviceability-dev
mailing list