RFR: 8343378: Exceptions in javax/management DeadLockTest.java do not cause test failure

[Kevin Walls]

On Thu, 31 Oct 2024 19:10:38 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Test update: fail when it hits an Exception.
>> 
>> This test still references jmxmp and iiop, which are of course redundant, there are various tests that still do this.
>> I am working on http, so we may revisit these tests in future to change their list of protocols.
>> 
>> For now, I'd like to simply make this test fail if any of the protocols it tests have failures.
>> Fix a few typos while we are here.
>
> test/jdk/javax/management/remote/mandatory/connection/DeadLockTest.java line 54:
> 
>> 52:                 test(protocols[i]);
>> 53:             } catch (Exception e) {
>> 54:                 fail = true; // any one protocol failure, fails the test
> 
> Suggestion:
> 
>                 fail = true; // any one protocol failure fails the test

I actually think it's more readable with the comma.
If there is (one protocol failure), then that (fails the test).
Without the comma, "failure fails" runs together, but the failure did not fail, it was a perfectly good failure.  Pause for breath. What do we do now?  Well, experiencing that kind of problem, fails the test.

Extended discussions on language style, from the test that brought you "listner" and "should no block". 8-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21804#discussion_r1825154594