RFR: 8338894: Deprecate jhsdb debugd for removal [v2]

[Kevin Walls]

On Tue, 3 Sep 2024 20:07:16 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/jdk.hotspot.agent/doc/transported_core.html
>>    
>>    Co-authored-by: Chris Plummer <chris.plummer at oracle.com>
>>  - Update src/jdk.hotspot.agent/doc/index.html
>>    
>>    Co-authored-by: Chris Plummer <chris.plummer at oracle.com>
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/DebugServer.java line 31:
> 
>> 29: import sun.jvm.hotspot.oops.*;
>> 30: 
>> 31: @Deprecated(since="24", forRemoval=true)
> 
> I didn't even realize this class existed. So this an (undocumented) way to start the debug server. Is there some other class that connects to it other than using `jhsdb --connect`?

Right, I think this class is an orphan, it has no users.
The HotSpotAgent constructor mentions DebugServer in one comment, but does not use it, and probably means to say "startServer".  This comment should be updated when startServer is eventually removed.

Checking older releases, there used to be shell scripts which invoked DebugServer, and an SADebugServer class which invoked DebugServer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20830#discussion_r1743438833