RFR: 8338894: Deprecate jhsdb debugd for removal [v4]

[Kevin Walls]

On Wed, 4 Sep 2024 19:38:37 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   --connect option text, not a WARNING
>
> test/hotspot/jtreg/serviceability/sa/sadebugd/ClhsdbTestConnectArgument.java line 78:
> 
>> 76:             System.err.println(out.getStderr());
>> 77: 
>> 78:             out.shouldMatch("WARNING: --connect is deprecated");
> 
> You might want to consider improving stderrShouldBeEmptyIgnoreDeprecatedWarnings(). It could, for instance, do a case insensitive search for "warning" and "deprecated" rather than the more specific search it is currently doing. Just a suggestion. Don't bother if you don't think it is worth it.

I had looked at doing that but was worried about missing other real messages.
However looking again, to match "^WARNING: .* is deprecated.*" seems quite unambiguous!
Will update...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20830#discussion_r1745288322