RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v2]

[David Holmes]

On Thu, 5 Sep 2024 10:04:14 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - simplify windwos realpath() implementation
>>  - get rid of os::posix::realpath() and os::win32::realpath()
>
> src/hotspot/os/posix/os_posix.cpp line 1027:
> 
>> 1025: }
>> 1026: 
>> 1027: char* os::Posix::realpath(const char* filename, char* outbuf, size_t outbuflen) {
> 
> I'm looking at this from the GitHub UI so I might be missing something, but why was this moved up?

I'd assume because it is now os::foo rather than os::Posix::foo - though such a move is not necessary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1746156926