RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v2]

Thomas Stuefe stuefe at openjdk.org
Fri Sep 6 10:41:53 UTC 2024


On Thu, 5 Sep 2024 12:28:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/os/windows/os_windows.cpp line 5327:
>> 
>>> 5325: 
>>> 5326:   char* result = nullptr;
>>> 5327:   ALLOW_C_FUNCTION(::_fullpath, result = ::_fullpath(outbuf, filename, outbuflen);)
>> 
>> Would this work for non-Latin-1 utf-8?
>
> According to the docs:
>> _fullpath automatically handles multibyte-character string arguments as appropriate, recognizing multibyte-character sequences according to the multibyte code page currently in use.

Thanks,, David :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1746914038


More information about the serviceability-dev mailing list