RFR: 8338890: Add monitoring/management interface for the virtual thread scheduler [v3]
Alan Bateman
alanb at openjdk.org
Fri Sep 6 11:11:51 UTC 2024
On Fri, 6 Sep 2024 10:47:29 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
> The ObjectName String "jdk.management:type=VirtualThreadScheduler" could have a public static final definition somewhere in future, but there is no obvious home, e.g. java.lang.management.ManagementFactory is in the wrong package. Something for the future, not for this change, as I others that don't have such a symbol.
JMX pre-dates default methods, one thing to explore is if the interfaces that extend PlatformManagedObject could have getObjectName as the default method. That would avoid needing to write this method in the implementation classes.
> src/jdk.management/share/classes/jdk/management/VirtualThreadSchedulerMXBean.java line 34:
>
>> 32:
>> 33: /**
>> 34: * Management interface for the JDK's {@linkplain Thread##virtual-threads virtual thread}
>
> is this "Management interface for **a**" virtual thread scheduler, as in future it may be the interface generically for virtual thread schedulers?
It's singular for now, so "the" is correct.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20816#issuecomment-2333818694
PR Review Comment: https://git.openjdk.org/jdk/pull/20816#discussion_r1746944191
More information about the serviceability-dev
mailing list