RFR: 8339638: Update vmTestbase/nsk/jvmti/*Field*Watch tests to use virtual thread factory
Leonid Mesnik
lmesnik at openjdk.org
Fri Sep 6 20:03:04 UTC 2024
On Fri, 6 Sep 2024 19:52:19 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Field watch tests updated to be executed with virtual threads when virtual test thread factory enabled.I added
>> jdk.test.lib.thread.TestThreadFactory
>> to created test threads so they support virtual thread factory jtreg plugin.
>>
>> It might makes sense to use it in different tests so virtual threads are tests more extensively.
>> There is JDIThreadFactory in nsk/sharejdi which I copied. I am going to update JDI tests to use jdk.test.lib.thread.TestThreadFactory
>> later.
>
> test/lib/jdk/test/lib/thread/TestThreadFactory.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.
>
> Should just be 2024.
I copied file from JDIThreadFactory,java (I mention this in PR) and I left copyrights from original. I think it is the correct way to treat copyrights. Not sure, if I can find policy about this though.
If you think that new file require current year only, I am fine to update it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20897#discussion_r1747653242
More information about the serviceability-dev
mailing list