RFR: 8337563: NMT: rename MEMFLAGS to MemTag

[David Holmes]

On Sat, 7 Sep 2024 05:11:25 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>> 
>> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemTag` is a more suitable name.
>> 
>> This fix also includes a cleanup of all the related parameter names and local variable names.
>> 
>> Testing is pending...
>> 
>> Note: there is more history in old closed PRs [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) and [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472)
>
> src/hotspot/share/gc/shared/taskqueue.hpp line 119:
> 
>> 117: // TaskQueueSuper collects functionality common to all GenericTaskQueue instances.
>> 118: 
>> 119: template <unsigned int N, MemTag F>
> 
> MemTag parameter name should probably be changed here and elsewhere in taskqueue code.
> Suggest `mem_tag`.

I was going to suggest just MT which is more in keeping with the short/terse names given to type parameters.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20872#discussion_r1749405959