RFR: 8337563: NMT: rename MEMFLAGS to MemTag

[Gerard Ziemski]

On Sat, 7 Sep 2024 05:21:50 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>> 
>> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemTag` is a more suitable name.
>> 
>> This fix also includes a cleanup of all the related parameter names and local variable names.
>> 
>> Testing is pending...
>> 
>> Note: there is more history in old closed PRs [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) and [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472)
>
> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 63:
> 
>> 61:     static void* allocate_node(void* context, size_t size, Value const& value) {
>> 62:       ObjectMonitorTable::inc_items_count();
>> 63:       return AllocateHeap(size, MemTag::mtObjectMonitor);
> 
> pre-existing: Why the scope here and below?

Good question, I will clean this up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20872#discussion_r1750614387