RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v6]
Roman Kennke
rkennke at openjdk.org
Tue Sep 10 07:23:13 UTC 2024
On Mon, 9 Sep 2024 10:16:24 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/hotspot/share/gc/shared/gcForwarding.hpp line 41:
>
>> 39: * bits (to indicate 'forwarded' state as usual).
>> 40: */
>> 41: class GCForwarding : public AllStatic {
>
> Since this class is only used for Full GCs, it may be useful to include that information, i.e. something like `FullGCForwarding` to avoid confusion why it is not used for other GCs too.
> (Unless this has been discussed and even rejected by me before).
I agree. In-fact, that has been my original name. It has been suggested that I change it to SlidingForwarding when that was the approach that we were going to take, but with the new implementation, FullGCForwarding makes most sense. I'll change it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1751400378
More information about the serviceability-dev
mailing list