RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map [v8]

[Sonia Zaldana Calles]

On Tue, 27 Aug 2024 22:58:52 GMT, Simon Tooke <stooke at openjdk.org> wrote:

>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to Windows.
>> 
>> System.map and System.dump_map are implemented using the Windows API and provide roughly the same information in the same format.  Most of the heavy lifting was implemented by @tstuefe in #16301 - this PR adds the Windows implementation and enables the common code for Windows 64 bit.
>>  
>> [Sample output (with NMT enabled)](https://github.com/user-attachments/files/16663332/vm_memory_map_760.txt)
>
> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix overly restrictive test

I am not a Reviewer but this looks mostly good to me.

src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:

> 96:       out.put('r');
> 97:     } else {
> 98:          fatal("Unknown Windows memory state value: 0x%x", mem_info.State);

Small nit - indentation.

src/hotspot/share/services/diagnosticCommand.hpp line 984:

> 982: };
> 983: 
> 984: #if defined(LINUX) || defined(_WIN64)

We also need to update the description for the diagnostic commands. Currently, both `System.dump_map` and `System.map` state they're enabled for linux only.

-------------

Changes requested by szaldana (Committer).

PR Review: https://git.openjdk.org/jdk/pull/20597#pullrequestreview-2292809350
PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1752161474
PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1752167618