RFR: 8337563: NMT: rename MEMFLAGS to MemTag [v5]

Gerard Ziemski gziemski at openjdk.org
Tue Sep 10 20:53:47 UTC 2024


On Tue, 10 Sep 2024 20:28:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix test
>
> src/hotspot/share/nmt/memTracker.hpp line 265:
> 
>> 263: 
>> 264:   // MallocLimt: Given an allocation size s, check if mallocing this much
>> 265:   // under category f would hit either the global limit or the limit for mem_tag.
> 
> I don't know what "category f" is.   Maybe reword as
> 
>     // MallocLimit: Given an allocation size s, check if allocating this much memory would hit the global limit or the
>     // limit tagged with mem_tag.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20872#discussion_r1752704620


More information about the serviceability-dev mailing list