RFR: 8337563: NMT: rename MEMFLAGS to MemTag [v7]
Gerard Ziemski
gziemski at openjdk.org
Tue Sep 10 20:57:07 UTC 2024
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also includes a cleanup of all the related parameter names and local variable names.
>>
>> Testing is pending...
>>
>> Note: there is more history in old closed PRs [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) and [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472)
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>
> Coleen's feedback
I went with `MT` throughout the code for all MemTag template parameter names. It will be a nice mental shortcut once we get used to the change...
I did not want to rock the boat too much and decided not to use `mem_tag` for template parameter names, it just did not look good next to the other names, with all capital letters.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20872#issuecomment-2341992426
More information about the serviceability-dev
mailing list