RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map [v9]

[Simon Tooke]

On Wed, 11 Sep 2024 14:12:48 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - prevent VM crash on invalid jcmd
>>  - changes from review
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1196:
> 
>> 1194: void SystemDumpMapDCmd::execute(DCmdSource source, TRAPS) {
>> 1195:   const char* name = _filename.value();
>> 1196:   if (name == NULL || *name == 0) {
> 
> Can you please change this to `(*name) == '\0'` or `name[0] == '\0'` ?

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1754807454