RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map [v10]

[Simon Tooke]

On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke <stooke at openjdk.org> wrote:

>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to Windows.
>> 
>> System.map and System.dump_map are implemented using the Windows API and provide roughly the same information in the same format.  Most of the heavy lifting was implemented by @tstuefe in #16301 - this PR adds the Windows implementation and enables the common code for Windows 64 bit.
>>  
>> [Sample output (with NMT enabled)](https://github.com/user-attachments/files/16663332/vm_memory_map_760.txt)
>
> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changes per review

> Hi Simon,
> 
> Thanks! Looks good.
> 
> Just had a question about the empty filename issue. I don’t think there is a case where a filename parameter should accept an empty string (but I might be wrong).
> 
> If that’s the case, I wonder if it would be better to just deal with all empty filename parameter errors in the dcmd argument parser.
> 
> ```
> 
> I haven't tested this but this would probably be better handled in a separate RFE though.

I agree, and will probably do this next week.  If it looks good to you, could you please mark as reviewed?  You're on the list of reviewers.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20597#issuecomment-2343899268