RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map [v10]

[Simon Tooke]

On Wed, 11 Sep 2024 14:59:52 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changes per review
>
> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
> 
>> 96:       out.put('r');
>> 97:     } else {
>> 98:       fatal("Unknown Windows memory state value: 0x%x", mem_info.State);
> 
> Are these really fatal?  We don't want to risk ending the target process with a jcmd.  Maybe a warning, as part of the command output (not the JVM's stdout/err) if we want to say something?

I was thinking about this - my original intent was to be fatal only on a debug build, not release.  I have added a message in the output, and changed these to warnings (for both release and debug)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1755205972