RFR: 8338471: Refactor Method::get_new_method() for better NoSuchMethodError handling [v4]

[Dean Long]

On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This patch cleans up the use of `get_new_method()` so callers don't have to worry about throwing `NoSuchMethodError`. The method is refactored to throw the error and avoid ever returning nullptr. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Coleen suggestion

I think the JVMTI API I was thinking of was PopFrame, which says:
" the operand stack is restored--the argument values are added back and if the invoke was not invokestatic, objectref is added back as well "
" Note however, that any changes to the arguments, which occurred in the called method, remain; when execution continues, the first instruction to execute will be the invoke."

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20874#issuecomment-2345219547