RFR: 8337563: NMT: rename MEMFLAGS to MemTag [v7]

Johan Sjölen jsjolen at openjdk.org
Thu Sep 12 08:49:08 UTC 2024


On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>> 
>> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemTag` is a more suitable name.
>> 
>> This fix also includes a cleanup of all the related function/template parameter names and local variable names.
>> 
>> Testing is pending...
>> 
>> Note: there is more history in old closed PRs [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) and [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472)
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Coleen's feedback

Hi! I went through all of it and LGTM, one question about copyright notices however.

src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.inline.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2016, 2019, Red Hat, Inc. All rights reserved.

I don't think we're meant to update other companies' copyrights?

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20872#pullrequestreview-2299601404
PR Review Comment: https://git.openjdk.org/jdk/pull/20872#discussion_r1756401544


More information about the serviceability-dev mailing list