RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v5]
Simon Tooke
stooke at openjdk.org
Thu Sep 12 13:56:42 UTC 2024
> This PR changes the status of realpath() from a Posix-specific API to a globally available API, i.e. adding it to the "Hotspot Porting API". Code would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires the addition of a stub routine in os_posix.cpp and a Windows implementation of realpath(), using Windows _fullpath().
>
> This PR depends on #20597 in that it removes the need for one #ifdef in that PR. Because of that, this PR will be modified when and if #20597 is integrated.
>
> Please note that guidelines for doing this appear in src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with three additional commits since the last revision:
- remove empty line
- fix indentation
- fix missing return statement
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20683/files
- new: https://git.openjdk.org/jdk/pull/20683/files/9d9418d0..33c4b402
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20683&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20683&range=03-04
Stats: 3 lines in 3 files changed: 1 ins; 1 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/20683.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20683/head:pull/20683
PR: https://git.openjdk.org/jdk/pull/20683
More information about the serviceability-dev
mailing list