RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v4]

[Simon Tooke]

On Thu, 12 Sep 2024 00:47:21 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   properly test for buffer too small for path
>
> src/hotspot/os/posix/os_posix.cpp line 990:
> 
>> 988: }
>> 989: 
>> 990: 
> 
> Spurious extra line ?

done.

> src/hotspot/os/windows/os_windows.cpp line 5337:
> 
>> 5335:     ALLOW_C_FUNCTION(::free, ::free(p);) // *not* os::free
>> 5336:   }
>> 5337: }
> 
> You have forgotten to return `result`.

done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1756920370
PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1756921115