RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v5]

Simon Tooke stooke at openjdk.org
Thu Sep 12 13:56:43 UTC 2024


On Wed, 11 Sep 2024 14:31:43 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - remove empty line
>>  - fix indentation
>>  - fix missing return statement
>
> src/hotspot/os/posix/os_posix.cpp line 1031:
> 
>> 1029: 
>> 1030: // Sleep forever; naked call to OS-specific sleep; use with CAUTION
>> 1031: void os::infinite_sleep() {
> 
> Ouch, looks like something broke in one of the commits, the new diff it's showing isn't pretty (infinite_sleep and friends have been displaced in the file, at least on my end)

caught and fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1756919153


More information about the serviceability-dev mailing list