RFR: 8337563: NMT: rename MEMFLAGS to MemTag [v9]

Gerard Ziemski gziemski at openjdk.org
Thu Sep 12 15:45:11 UTC 2024


On Thu, 12 Sep 2024 15:32:57 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>> 
>> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemTag` is a more suitable name.
>> 
>> This fix also includes a cleanup of all the related function/template parameter names and local variable names.
>> 
>> Testing is pending...
>> 
>> Note: there is more history in old closed PRs [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) and [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472)
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Afshin's feedback

I have incorporated Afshin feedback, but can revert the changes and punt them to a followup if there is a pushback against doing it right now.

I think that we are now in pretty good shape. I could use final approvals, with anything that's not critical to be done in followup(s) later.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20872#issuecomment-2346637453


More information about the serviceability-dev mailing list