RFR: 8337563: NMT: rename MEMFLAGS to MemTag [v11]

Coleen Phillimore coleenp at openjdk.org
Thu Sep 12 16:01:15 UTC 2024


On Thu, 12 Sep 2024 15:52:41 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>> 
>> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemTag` is a more suitable name.
>> 
>> This fix also includes a cleanup of all the related function/template parameter names and local variable names.
>> 
>> Testing is pending...
>> 
>> Note: there is more history in old closed PRs [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) and [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472)
>
> Gerard Ziemski has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - copyrights
>  - Afshin's feedback, tests

This looks good to me. Thanks for finding some additional cases, Afshin.  Thanks also for  updating the copyrights.  Thanks for this effort for consensus and for the change, Gerard.

Edit: please let GHA complete.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20872#pullrequestreview-2300775940


More information about the serviceability-dev mailing list