RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map [v10]

Kevin Walls kevinw at openjdk.org
Thu Sep 12 19:46:08 UTC 2024


On Thu, 12 Sep 2024 15:34:47 GMT, Simon Tooke <stooke at openjdk.org> wrote:

> concerns with my use of 'fatal()' by replacing with a message in the returned output and an assert().
> 
> I have also adjusted the spacing of the offset field in the output, but kept it for parity with the Linux version.

Thanks @stooke !

Thanks for making it non-fatal.
Printing a message on an unknown field will break the format?  I don't want to cause a great disturbance on this as it should "never happen" so this is fine, or doing nothing and having the assert for debug builds.

Re: offset column: I don't see an offset column in Linux, I see an rss column?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20597#issuecomment-2347105107


More information about the serviceability-dev mailing list