RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v14]

Roman Kennke rkennke at openjdk.org
Fri Sep 13 08:21:55 UTC 2024


On Fri, 13 Sep 2024 07:54:30 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> src/hotspot/share/cds/filemap.cpp line 2457:
>> 
>>> 2455:                           compressed_oops(), compressed_class_pointers());
>>> 2456:   if (compressed_oops() != UseCompressedOops || compressed_class_pointers() != UseCompressedClassPointers) {
>>> 2457:     log_info(cds)("Unable to use shared archive.\nThe saved state of UseCompressedOops and UseCompressedClassPointers is "
>> 
>> The promotion of this CDS log line from `info` to `warning` triggers false failures in the `test/hotspot/jtreg/compiler/intrinsics/bmi` tests when running them with `-XX:-UseCompressedClassPointers`. These tests expect the standard output of different JVM runs to be identical, but the timestamps in the log messages tend to differ. I suggest adjusting the test configuration so that log timestamps are simply omitted, as in [this patch](https://github.com/robcasloz/jdk/commit/48f6e90ef6e0a71b55df536ed04a8b72130b5ea9) (feel free to merge it as-is or with any further changes you may find necessary).
>
> This comment has been marked as "resolved" without any apparent action being taken, is that intentional?

I have merged your patch locally but forgot to push it. Sorry.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1758407575


More information about the serviceability-dev mailing list