RFR: 8338471: Refactor Method::get_new_method() for better NoSuchMethodError handling [v4]

[Coleen Phillimore]

On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This patch cleans up the use of `get_new_method()` so callers don't have to worry about throwing `NoSuchMethodError`. The method is refactored to throw the error and avoid ever returning nullptr. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Coleen suggestion

So maybe instead of returning Unsafe::no_such_method_exception() we should just have a fatal error with the message that the method has been deleted.  The user is privileged by using redefinition and is using a deprecated option.  Maybe that's the best response.  Opinions?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20874#issuecomment-2348933420