RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v5]

[Simon Tooke]

On Fri, 13 Sep 2024 05:57:13 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - remove empty line
>>  - fix indentation
>>  - fix missing return statement
>
> src/hotspot/os/windows/os_windows.cpp line 5334:
> 
>> 5332:     } else {
>> 5333:       errno = ENAMETOOLONG;
>> 5334:     }
> 
> Curious, why not just passing in outbuf and outbuflen directly instead of letting the function allocate memory just to then copy the content? To get a guaranteed ENAMETOOLONG?
> 
> Just a question, not a comment. I am fine with this as it is.

That's exactly it - I don't know what different versions of Windows do.  I do know, for instance, that my Windows 10 vm sets errno to ERANGE (I could simplify the code and just test and convert that, but I'm being cautious, I guess).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1759247376