RFR: 8338471: Refactor Method::get_new_method() for better NoSuchMethodError handling [v4]

Mon Sep 16 17:23:07 UTC 2024

On Sat, 14 Sep 2024 08:09:04 GMT, David Holmes <dholmes at openjdk.org> wrote:

> A refactoring should not change behaviour. Maybe this only looked like an opportunity for refactoring but in reality is not?
The change of behavior here is there will no longer be any potential crashes resulting from `get_new_method()` returning a nullptr. The callers no longer have to worry about throwing NSME because it is taken care of inside the function.

Before this patch, the callers either check for is_old() or expect the new method to never be null. The goal here is to take care of all that inside the method while maintaining functionality. 

Also Dean opened a new issue here with regards to ciMethod::equals
[JDK-8340141](https://bugs.openjdk.org/browse/JDK-8340141)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20874#issuecomment-2353489867