RFR: 8340213: jcmd VM.events ignores max argument

Sonia Zaldana Calles szaldana at openjdk.org
Mon Sep 16 19:38:05 UTC 2024


On Mon, 16 Sep 2024 19:14:01 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The inner  'int max;' declaration hide previous max.

I am not a Reviewer but this looks good to me.

test/hotspot/jtreg/serviceability/dcmd/vm/EventsTest.java line 81:

> 79:         long lines = output.asLines().stream().filter(x -> x.contains("Loading class")).count();
> 80:         Assert.assertTrue(lines == MAX, "There are should be " + MAX + " lines");
> 81:         output.stdoutShouldNotMatch(buildHeaderPattern("Events"));

Could also check the output contains the selected event category like in `run_selected` above.

-------------

Marked as reviewed by szaldana (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21024#pullrequestreview-2307606287
PR Review Comment: https://git.openjdk.org/jdk/pull/21024#discussion_r1761773080


More information about the serviceability-dev mailing list