RFR: 8340213: jcmd VM.events ignores max argument [v2]

Sonia Zaldana Calles szaldana at openjdk.org
Mon Sep 16 19:54:38 UTC 2024


On Mon, 16 Sep 2024 19:51:20 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The inner  'int max;' declaration hide previous max.
>
> Leonid Mesnik has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - typo fixed.
>  - check added.

Thanks!

test/hotspot/jtreg/serviceability/dcmd/vm/EventsTest.java line 42:

> 40: public class EventsTest {
> 41: 
> 42:     // MAX should be less then number of actually recored events

Nit, spelling for `than` and `recorded`.

-------------

Marked as reviewed by szaldana (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21024#pullrequestreview-2307637621
PR Review Comment: https://git.openjdk.org/jdk/pull/21024#discussion_r1761784597


More information about the serviceability-dev mailing list