RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v8]

Simon Tooke stooke at openjdk.org
Wed Sep 18 10:18:29 UTC 2024


On Wed, 18 Sep 2024 03:59:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Define MAX_PATH if required
>
> test/hotspot/gtest/runtime/test_os.cpp line 386:
> 
>> 384: 	const char* returnedBuffer = os::realpath(path, buffer, 10);
>> 385:   EXPECT_TRUE(errno == ENAMETOOLONG);
>> 386:   EXPECT_TRUE(returnedBuffer == nullptr);
> 
> Indentation is off through this code.

thanks!  fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1764793111


More information about the serviceability-dev mailing list