RFR: 8338471: Refactor Method::get_new_method() for better NoSuchMethodError handling [v4]

[Dean Long]

On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This patch cleans up the use of `get_new_method()` so callers don't have to worry about throwing `NoSuchMethodError`. The method is refactored to throw the error and avoid ever returning nullptr. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Coleen suggestion

src/hotspot/share/oops/method.hpp line 854:

> 852:     Method* new_method = method_holder()->method_with_idnum(orig_method_idnum());
> 853:     assert(this != new_method, "sanity check");
> 854:     assert(new_method != nullptr || is_deleted(), "must be");

Suggestion:

    assert((new_method == nullptr) == (old_method->is_deleted()), "must be");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20874#discussion_r1765506638