RFR: 8338471: Refactor Method::get_new_method() for better NoSuchMethodError handling [v4]

[Dean Long]

On Wed, 18 Sep 2024 19:00:52 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> resolved_indy_entries.method is the adapter method which can't be deleted, we could add an assert about that.

OK, please do.

If CallInfo::resolved_method() can return an old method, then it could also return a deleted method, which would cause a null pointer crash before this change.  Have we seen such crashes?  It would mean the caller did a successful resolve but then decided to safepoint  before calling resolved_method().  With this change, we return a method with the wrong name and signature, which I still have concerns about.  Even though we did this before in other places, this is a change in behavior to do it here.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20874#issuecomment-2359276019