RFR: 8340391: Windows jcmd System.map and System.dump_map tests failing
Thomas Stuefe
stuefe at openjdk.org
Fri Sep 20 08:52:49 UTC 2024
On Fri, 20 Sep 2024 05:54:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> New test is failing on Windows with ZGC: the regex for JAVAHEAP is not matching.
>>
>> Matching "mapped", as well as "private", is testing OK for me: ZGC JAVAHEAP is not private in terms of Windows _MEMORY_BASIC_INFORMATION
>>
>> Simple regex update to a new test which is failing - I'd like to push this as a trivial change.
>
> Hmm, the fix is unnecessarily broad in that it changes the matching to pass for file mappings for all committed sections. We only use file mappings for the java heap for ZGC.
>
> See some lines up, where I solved this for Linux with a separate regex for the java heap.
>
> I filed https://bugs.openjdk.org/browse/JDK-8340496 as a follow-up.
> Thanks @tstuefe I was seeing a lot of test failure notifications, and felt under significant pressure to make them go away, so this was done quickly. Following up with a better solution is great.
Oh, no problem. Thanks for fixing this so quickly. These are not urgent issues, we can clean them up in our own time.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21073#issuecomment-2363202873
More information about the serviceability-dev
mailing list