RFR: 8340524: Remove NarrowPtrStruct

[Julian Waters]

On Sat, 21 Sep 2024 04:19:13 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change which removes the class NarrowPtrStruct. The only
> place it was still being used was as the type of CompressedOops::_narrow_oops.
> Instead, we move the members from NarrowPtrStruct directly into
> CompressedOops, flattening its structure.
> 
> Testing: mach5 tier1-3
> Tiers 2&3 run serviceability tests that hit the changes to that component.

Took me a while to work through the confusing diff in one of the files, but this looks ok

src/hotspot/share/oops/compressedOops.hpp line 37:

> 35: class ReservedHeapSpace;
> 36: 
> 37: struct NarrowPtrStruct {

Not an objection, just a complaint on how the GitHub diff view makes this confusing to review

-------------

Marked as reviewed by jwaters (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21115#pullrequestreview-2320823566
PR Review Comment: https://git.openjdk.org/jdk/pull/21115#discussion_r1770523694