RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v6]

Thomas Stuefe stuefe at openjdk.org
Sun Sep 22 12:01:51 UTC 2024


On Fri, 20 Sep 2024 16:56:58 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix bit counts in GCForwarding
>
> src/hotspot/share/cds/archiveUtils.cpp line 348:
> 
>> 346:   old_tag = (int)(intptr_t)nextPtr();
>> 347:   // do_int(&old_tag);
>> 348:   assert(tag == old_tag, "tag doesn't match (%d, expected %d)", old_tag, tag);
> 
> Is this assert message change a leftover from debugging or is it meant to be this way?

Its a leftover, but otoh it does not hurt. I found myself re-adding it several times to analyze CDS issues during development, so I decided to just leave it in.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1770536320


More information about the serviceability-dev mailing list