RFR: 8352730: RISC-V: Disable tests in qemu-user [v3]
Robbin Ehn
rehn at openjdk.org
Tue Apr 8 09:44:23 UTC 2025
On Mon, 31 Mar 2025 10:45:54 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, for you to consider.
>>
>> These tests constantly fails in qemu-user.
>> Either the require host to be same arch explicit or implicit (sysroot).
>> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'" for SA tests.
>>
>> From bug:
>>> qemu-user/rv64 sets uarch to "qemu" in /proc/cpuinfo (qemu-system do not do that).
>>> We add this uarch to CPU feature string.
>>> This means we can use jtreg 'require' with cpu string to filter out tests in qemu-user.
>>
>> Relevant qemu code:
>> https://github.com/qemu/qemu/blob/170825d14d88a1ce7fae98d5a928480f2f329b22/linux-user/riscv/target_proc.h#L29
>>
>> Relevant hotspot code:
>> https://github.com/openjdk/jdk/blob/fa0b18bfde38ee2ffbab33a9eaac547fe8aa3c7c/src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp#L250
>>
>> Tested that the require only filters out tests in qemu+riscv64.
>>
>> Thanks!
>>
>> /Robbin
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Merge branch 'master' into qemu-user-issues
> - Revert
> - Merge branch 'master' into qemu-user-issues
> - Merge branch 'master' into qemu-user-issues
> - more
> - more
> - native or very long
Any takers?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24229#issuecomment-2785851072
More information about the serviceability-dev
mailing list