RFR: 8353727: HeapDumpPath doesn't expand %p [v4]

[Kevin Walls]

On Wed, 9 Apr 2025 11:04:26 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> This is a long-standing oversight: HeapDumpPath does not recognise %p for pid expansion.
>> The default filename uses a pid (e.g. java_pid1676937.hprof) but HeapDumpPath does not.
>> It has always done a manual "root plus pid plus extension" on the default filename only, and
>> should move to using Argument::copy_expand_pid() like we do with other such filenames.
>> 
>> 
>> We also assumed the default filename is not a directory (which is very very likely, but doesn't have to be true).
>
> Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into HeapDumpPath_pid
>  - test feedback
>  - length checking update
>  - Chris feedback
>  - 8353727: HeapDumpPath doesn't expand %p

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24482#issuecomment-2789998024