RFR: 8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y [v2]
Hendrik Schick
duke at openjdk.org
Thu Apr 10 21:34:30 UTC 2025
On Thu, 10 Apr 2025 20:31:13 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Don't use includevirtualthreads=y unless the test requires it. Debuggers don't usually use includevirtualthreads=y, so we should be doing most of our testing without it. The only reason tests use it is because some tests need it so they can find virtual threads in the debuggee by using vm.allThreads(). This change limits the use of includevirtualthreads=y to just those com/sun/jdi tests that need it.
>>
>> Tested by running com/sun/jdi tests on all supported platforms in both platform threads mode and virtual threads mode. Also tested with tier1 CI.
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix copyright.
test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java line 1:
> 1: /*
update copyright to 2025 here aswell?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24583#discussion_r2038371614
More information about the serviceability-dev
mailing list