RFR: 8353955: nsk/jdi tests should be fixed to not always require includevirtualthreads=y [v2]

Chris Plummer cjplummer at openjdk.org
Thu Apr 17 20:35:19 UTC 2025


> This is just a preliminary review. I'd like to get some approval for the approach I'm taking. There are over 300 tests that need to be fixed. I've just fixed a handful in this PR to give a feel for the changes I plan on making. If they look ok to you, then I'll update this PR with the needed changes to the rest of the tests.
> 
> What this PR is fixing is the issue with all of our nsk/jdi testing being done with includevirtualthreads=y even though debuggers typically use the default includevirtualthreads=n. As a result we have a testing gap with includevirtualthreads=n. There are nearly 1200 nsk/jdi tests. Only about 350 actually need includevirtualthreads=y. I plan making includevirtualthreads=n the default for nsk/jdi tests unless the test does something to override the default and request includevirtualthreads=y.
> 
> includevirtualthreads=y forces the debug agent to track all virtual threads so they are returned by vm.allThreads(). Some tests need this since they use vm.allThreads() to find the debuggee threads. Without includevirtualthreads=y, vm.allThreads() usually won't return any virtual threads (although it might return some for which events have been triggered).

Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:

  Add support for -includevirtualthreads test argument.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24606/files
  - new: https://git.openjdk.org/jdk/pull/24606/files/a3298d3f..d59e2ee9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24606&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24606&range=00-01

  Stats: 74 lines in 32 files changed: 31 ins; 34 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/24606.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24606/head:pull/24606

PR: https://git.openjdk.org/jdk/pull/24606


More information about the serviceability-dev mailing list