RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v2]

[Chris Plummer]

On Fri, 18 Apr 2025 09:30:24 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Currently if loading a core file fails, the diagnostic information provided on different systems is different; on MacOS we produce an error message, while on Linux we only print information if debug logging is enabled.
>> 
>> This PR adds some new messages on Linux to match MacOSX, and changes some of the diagnostic output to error level instead of debug. Additionally, if opening the core or the exe file fails, the system error message (strerror) is printed.
>> 
>> Tier1-3 testing clean.
>
> Daniel Jeliński has updated the pull request incrementally with eight additional commits since the last revision:
> 
>  - Update copyright
>  - Add more error messages
>  - Add more error messages
>  - Add more error messages
>  - Add more error messages
>  - Add more error messages
>  - Add more error messages
>  - Add more error messages

Overall this looks great. Something I've wanted to do for a long time now but have never gotten around to. There are some places where I think you end up doubling up on error messages. For example, add_map_info() now prints an error message and so do its callers, but that's probably ok.

Please run all the SA tests in test/hotspot/jtreg/serviceability/sa and test/jdk/sun/tools/jhsdb on all our supported platforms.

Also test by hand attaching to both a core file and a process just to make sure you haven't turned any expected debug messages into error messages.

Thanks!

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24722#pullrequestreview-2779161259